linux-kernel - [PATCH] mfd/pcf50633: Terminate i2c_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090115134347.45a88999@hyperion.delvare>
Date:	Thu, 15 Jan 2009 13:43:47 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Balaji Rao <balajirrao@...nmoko.org>,
	Samuel Ortiz <sameo@...nedhand.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] mfd/pcf50633: Terminate i2c_device_id list

The i2c_device_id list is supposed to be zero-terminated.

Signed-off-by: Jean Delvare <khali@...ux-fr.org>
Cc: Balaji Rao <balajirrao@...nmoko.org>
Cc: Samuel Ortiz <sameo@...nedhand.com>
---
As a side note, I am currious why you set the driver_data to 0x73 and
then never use it...

 drivers/mfd/pcf50633-core.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.29-rc1.orig/drivers/mfd/pcf50633-core.c	2009-01-15 11:45:36.000000000 +0100
+++ linux-2.6.29-rc1/drivers/mfd/pcf50633-core.c	2009-01-15 13:31:22.000000000 +0100
@@ -678,6 +678,7 @@ static int __devexit pcf50633_remove(str
 
 static struct i2c_device_id pcf50633_id_table[] = {
 	{"pcf50633", 0x73},
+	{/* end of list */}
 };
 
 static struct i2c_driver pcf50633_driver = {


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/