[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090115144934.GA872@elte.hu>
Date: Thu, 15 Jan 2009 15:49:34 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Sam Ravnborg <sam@...nborg.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
Jaswinder Singh Rajput <jaswinderlinux@...il.com>,
Jaswinder Singh Rajput <jaswinder@...radead.org>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
Andrew Morton <akpm@...ux-foundation.org>,
David Miller <davem@...emloft.net>,
x86 maintainers <x86@...nel.org>,
LKML <linux-kernel@...r.kernel.org>,
netdev <netdev@...r.kernel.org>
Subject: Re: [PULL -tip] fixed few make headers_check warnings
* Sam Ravnborg <sam@...nborg.org> wrote:
> On Thu, Jan 15, 2009 at 12:11:34PM +0100, Ingo Molnar wrote:
> >
> > * Sam Ravnborg <sam@...nborg.org> wrote:
> >
> > > So when I see "capability.h: extern's make no sense in userspace" the
> > > perfect approach would be that the whole file was checked.
> > >
> > > This is a much bigger task that just removing the warning.
> >
> > The problem is, you just littered the kernel with a ton of warnings and
> > declared that fixing them is a 'much bigger task'.
> >
> > It's not good to start projects like this, because they simply never
> > finish. It's _much_ better to first reach a zero baseline via minimal
> > fixes, then enforce 'look at the whole thing' for all _NEW_ files and
> > changes.
> >
> > That's how we are using checkpatch in the -tip topics, and it's working
> > very nicely.
> >
> > Could we please start it like that?
>
> I would have done such have I had more time to do this stuff. Real life
> just hit me after vacation finished and deadline approaching.
>
> I can disable the warnings around -rc7 if we think they are too noisy
> when we release the next kernel.
they are perfectly fine i think, lets just not do the full approach now
and reach a zero baseline first. Then perfectionism can start again, at a
much more manageable flux.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists