[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090115221135.GA10283@elte.hu>
Date: Thu, 15 Jan 2009 23:11:35 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Roland McGrath <roland@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trailing whitespace in kernel/ptrace.c
* Roland McGrath <roland@...hat.com> wrote:
> These bug me every time I want to touch ptrace.c, nix them.
>
> Signed-off-by: Roland McGrath <roland@...hat.com>
> ---
> kernel/ptrace.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
btw., here's the checkpatch output from that file:
------------------>
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
#26: FILE: ptrace.c:26:
+#include <asm/uaccess.h>
ERROR: trailing whitespace
#51: FILE: ptrace.c:51:
+ $
WARNING: braces {} are not necessary for any arm of this statement
#63: FILE: ptrace.c:63:
+ if (child->signal->flags & SIGNAL_STOP_STOPPED) {
[...]
+ } else {
[...]
CHECK: memory barrier without comment
#157: FILE: ptrace.c:157:
+ smp_rmb();
ERROR: return is not a function, parentheses are not required
#172: FILE: ptrace.c:172:
+ return (!err ? true : false);
WARNING: line over 80 characters
#266: FILE: ptrace.c:266:
+int ptrace_readdata(struct task_struct *tsk, unsigned long src, char __user *dst, int len)
ERROR: trailing whitespace
#286: FILE: ptrace.c:286:
+^I^Ilen -= retval;^I^I^I$
WARNING: line over 80 characters
#291: FILE: ptrace.c:291:
+int ptrace_writedata(struct task_struct *tsk, char __user *src, unsigned long dst, int len)
ERROR: trailing whitespace
#311: FILE: ptrace.c:311:
+^I^Ilen -= retval;^I^I^I$
ERROR: else should follow close brace '}'
#425: FILE: ptrace.c:425:
+ }
+ else
WARNING: line over 80 characters
#455: FILE: ptrace.c:455:
+ ret = put_user(child->ptrace_message, (unsigned long __user *) data);
total: 5 errors, 6 warnings, 1 checks, 741 lines checked
kernel/ptrace.c has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists