[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090115.151914.84641343.davem@davemloft.net>
Date: Thu, 15 Jan 2009 15:19:14 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: w@....eu
Cc: jarkao2@...il.com, herbert@...dor.apana.org.au, zbr@...emap.net,
dada1@...mosbay.com, ben@...s.com, mingo@...e.hu,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
jens.axboe@...cle.com
Subject: Re: [PATCH] tcp: splice as many packets as possible at once
From: Willy Tarreau <w@....eu>
Date: Fri, 16 Jan 2009 00:03:31 +0100
> please don't merge it as-is. I've just tried it and got an OOM
> in __alloc_pages_internal after a few seconds of data transfer.
>
> I'm leaving the patch below for comments, maybe someone will spot
> something ? Don't we need at least one kfree() somewhere to match
> alloc_pages() ?
What is needed is a put_page().
But that should be happening as a result of the splice callback.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists