linux-kernel - Re: [PATCH 3/5] Add median filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090115154724.fe722ce3.akpm@linux-foundation.org>
Date:	Thu, 15 Jan 2009 15:47:24 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Nelson <arhuaco@...aks-unidos.net>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	andy@...nmoko.com
Subject: Re: [PATCH 3/5] Add median filter

On Tue, 13 Jan 2009 18:39:55 -0500
Nelson <arhuaco@...aks-unidos.net> wrote:

> +static void ts_filter_median_del(int *p, int value, int count)
> +{
> +	int index;
> +
> +	for (index = 0; index < count; index++)
> +		if (p[index] == value) {
> +			for (; index < count; index++)
> +				p[index] = p[index + 1];
> +			return;
> +		}
> +}
> +
> +
> +static void ts_filter_median_clear_internal(struct ts_filter *tsf)
> +{
> +	struct ts_filter_median *tsfm = (struct ts_filter_median *)tsf;
> +
> +	tsfm->pos = 0;
> +	tsfm->valid = 0;
> +
> +}
> +static void ts_filter_median_clear(struct ts_filter *tsf)
> +{
> +	ts_filter_median_clear_internal(tsf);
> +
> +	if (tsf->next) /* chain */
> +		(tsf->next->api->clear)(tsf->next);
> +}

Again, the code seems to do an awful lot of browsing over
exernally-visible data structures while holding no locks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/