linux-kernel - Re: PCI, ACPI, IRQ, IOAPIC: reroute PCI interrupt to legacy boot interrupt equivalent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901141710.33859.bjorn.helgaas@hp.com>
Date:	Wed, 14 Jan 2009 17:10:33 -0700
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Olaf Dabrunz <od@...e.de>
Cc:	Stefan Assmann <sassmann@...e.de>, Len Brown <lenb@...nel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org, Sven Dietrich <sdietrich@...ell.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Jon Masters <jcm@...hat.com>
Subject: Re: PCI, ACPI, IRQ, IOAPIC: reroute PCI interrupt to legacy boot interrupt equivalent

On Tuesday 13 January 2009 08:57:17 am Olaf Dabrunz wrote:
> On 13-Jan-09, Stefan Assmann wrote:
> > Bjorn Helgaas wrote:
> > > (I added Eric, Maciej, and Jon because they participated in
> > > previous discussion here: http://lkml.org/lkml/2008/6/2/269)
> > > 
> > > On Monday 12 January 2009 04:09:25 am Stefan Assmann wrote:
> > >> Len Brown wrote:
> > >>> Stefan,
> > >>> I had to exclude your changes to drivers/acpi/pci_irq.c from
> > >>> e1d3a90846b40ad3160bf4b648d36c6badad39ac
> > >>> in order to get some other changes to that file upstream in the
> > >>> 2.6.29 merge window. ...
> > >> Let me try to give you a short overview of what's happening there.
> > >>
> > >> If an IRQ arrives at line X of a non-primary IO-APIC and that line is
> > >> masked a new IRQ will be generated on the primary IO-APIC/PIC. This is
> > >> called a "Boot Interrupt" by Intel. It's purpose is, as the name
> > >> suggests, to ensure that the IRQ is handled at boot time (when the
> > >> non-primary) IO-APIC is still disabled.
> > >>
> > >> Condition to be met for "Boot Interrupts":
> > >> - line X on non-primary IO-APIC interrupt line is masked
> > >> - line X is asserted
> > > 
> > > Thanks.  Let me replay this to see whether I understand.  Please
> > > correct any of my misapprehensions :-)
> > > 
> > > Since your patch doesn't look at the IOxAPIC RDL register to see
> > > whether the pin is masked, you must be assuming that Linux is
> > > *always* using boot interrupts, and never unmasking the non-primary
> > > IOxAPIC entry.
> > 
> > Yes, for this special case that is correct.
> 
> Right. The current reroute code assumes that all interrupts use masking.

I'm not an expert in the "classic x86 ioapic behaviour" or in RT
interrupt handling.  My main objections are that the patch as proposed
is a gross hack in the ACPI _PRT lookup path, and that it didn't touch
the non-ACPI lookup path, which should have the same problem.  Now that
Eric pointed out this is just classic behavior, I also wonder why the
quirk doesn't list more devices.

The effect of the patch sounds sort of similar to using "noapic" --
you're basically ignoring the IOAPIC and using only the "boot interrupt"
or legacy PIC interrupt or whatever it is.  Can you contrast it with
that?

Bjorn


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/