linux-kernel - Re: Btrfs Snapshot Removal And General Project Status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1232119011.21473.24.camel@think.oraclecorp.com>
Date:	Fri, 16 Jan 2009 10:16:51 -0500
From:	Chris Mason <chris.mason@...cle.com>
To:	Tarkan Erimer <tarkan.erimer@...knet.net.tr>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Btrfs Snapshot Removal And General Project Status

On Wed, 2009-01-14 at 12:43 +0200, Tarkan Erimer wrote:
> Hi Chris,
> 

Sorry for the delay, I missed this one somehow.

> For the last few days, I was playing with btrfs. It looks really very 
> promising and fantastic! :-)

Glad to hear it worked.

> Thanks for everybody who involved with this amazing file system project! 
> ;-) Now, I play with snapshots. Creating snapshot is a breeze. 
> Recovering from snapshots work very well without any problems as far as 
> I tried. But; when I tried to remove the snapshot directories, I got an 
> error message that says : "cannot remove directory `snap1': Directory 
> not empty". But actually, it is empty. After that, I googled a bit and 
> found at "http://btrfs.wiki.kernel.org/index.php/Project_ideas" at 
> "Removal Snapshots" section, it states that it needs to be implement. 
> But, it's unclear which state this feature is now.
> 

That's right.  You did rm -rf dir, which is actually the slowest
possible way to remove the snapshot ;)  A much more optimized version is
possible, and already implemented as part of transaction commit.

But, the fast version is basically the same as unlinking a directory
that may or may not be in use.  We need to implement code to do that
properly wrt the VFS.

> It could be perfect to prepare a document that shows the current status 
> (completed, blah-blah % completed etc.) of the features,general status 
> of the project and maybe deadlines of feature implementions. Like : 
> "next release will have blah-blah features" etc.
> 

A very good point, I'm in the process of documenting this better.

> 
> BTW, is there any temporary way to remove these snapshot directories 
> before this "Remove Snapshot" feature implemented ? ;-)
> 

Unfortunately not, sorry.

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/