linux-kernel - Re: [patch 81/85] x86: fix RIP printout in early_idt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df9815e70901151927i29b0da1fh168c80cd80b754ae@mail.gmail.com>
Date:	Fri, 16 Jan 2009 11:27:57 +0800
From:	"Jike Song" <albcamus@...il.com>
To:	"Greg KH" <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	"Justin Forbes" <jmforbes@...uxtx.org>,
	"Zwane Mwaikambo" <zwane@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	"Randy Dunlap" <rdunlap@...otime.net>,
	"Dave Jones" <davej@...hat.com>,
	"Chuck Wolber" <chuckw@...ntumlinux.com>,
	"Chris Wedgwood" <reviews@...cw.f00f.org>,
	"Michael Krufky" <mkrufky@...uxtv.org>,
	"Chuck Ebbert" <cebbert@...hat.com>,
	"Domenico Andreoli" <cavokz@...il.com>, "Willy Tarreau" <w@....eu>,
	"Rodrigo Rubira Branco" <rbranco@...checkpoint.com>,
	"Jake Edge" <jake@....net>, "Eugene Teo" <eteo@...hat.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, "Jiri Slaby" <jirislaby@...il.com>,
	"Ingo Molnar" <mingo@...e.hu>
Subject: Re: [patch 81/85] x86: fix RIP printout in early_idt_handler

On Fri, Jan 16, 2009 at 6:02 AM, Greg KH <gregkh@...e.de> wrote:
> 2.6.27-stable review patch.  If anyone has any objections, please let us know.
>
> ------------------
>
> From: Jiri Slaby <jirislaby@...il.com>
>
> commit 7aed55d1085f71241284a30af0300feea48c36db upstream.
>
> Impact: fix debug/crash printout
>
> Since errorcode is popped out, RIP is on the top of the stack.
> Use real RIP value instead of wrong CS.
>
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
>
> ---
>  arch/x86/kernel/head_64.S |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/kernel/head_64.S
> +++ b/arch/x86/kernel/head_64.S
> @@ -305,7 +305,7 @@ ENTRY(early_idt_handler)
>        call dump_stack
>  #ifdef CONFIG_KALLSYMS
>        leaq early_idt_ripmsg(%rip),%rdi
> -       movq 8(%rsp),%rsi       # get rip again
> +       movq 0(%rsp),%rsi       # get rip again
>        call __print_symbol
>  #endif
>  #endif /* EARLY_PRINTK */

why not:

    movq (%rsp), %rsi

instead? Yes, it's all the same but 0 is just unnecessary.

-- 
Thanks,
Jike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/