linux-kernel - [PATCH] hp-wmi: fix regressions caused by missing if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 17 Jan 2009 01:55:01 +0100
From:	Frans Pop <elendil@...net.nl>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	linux-acpi@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH] hp-wmi: fix regressions caused by missing if statement

From: Frans Pop <elendil@...net.nl>

hp-wmi: fix regressions caused by missing if statement
    
Error was introduced in commit fe8e4e039dc3.
    
Signed-off-by: Frans Pop <elendil@...net.nl>
---
> On Saturday 17 January 2009, Frans Pop wrote:
> > When I first booted .29-rc2 my HP 2510p notebook hung while loading
> > hp-wmi, which I have listed in /etc/modules. Hard poweroff was
> > needed.

And this obvious patch fixes the regression (tested).

Andrew: I've added you as the broken patch also went via you.

diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index 7c789f0..6260420 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -441,6 +441,7 @@ static int __init hp_wmi_bios_setup(struct 
platform_device *device)
 		bluetooth_rfkill->toggle_radio = hp_wmi_bluetooth_set;
 		bluetooth_rfkill->user_claim_unsupported = 1;
 		err = rfkill_register(bluetooth_rfkill);
+		if (err)
 			goto register_bluetooth_error;
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/