linux-kernel - Re: [PATCH] leds: Fix bounds checking of wm8350->pmic.led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 17 Jan 2009 16:20:34 +0000
From:	Liam Girdwood <lrg@...nel.org>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	rpurdie@...ys.net, broonie@...nsource.wolfsonmicro.com,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: Fix bounds checking of wm8350->pmic.led

On Sat, 2009-01-17 at 16:06 +0100, Roel Kluin wrote:
> Fix bounds checking of wm8350->pmic.led
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/drivers/regulator/wm8350-regulator.c b/drivers/regulator/wm8350-regulator.c
> index 7aa3524..5056e23 100644
> --- a/drivers/regulator/wm8350-regulator.c
> +++ b/drivers/regulator/wm8350-regulator.c
> @@ -1435,7 +1435,7 @@ int wm8350_register_led(struct wm8350 *wm8350, int lednum, int dcdc, int isink,
>  	struct platform_device *pdev;
>  	int ret;
>  
> -	if (lednum > ARRAY_SIZE(wm8350->pmic.led) || lednum < 0) {
> +	if (lednum >= ARRAY_SIZE(wm8350->pmic.led) || lednum < 0) {
>  		dev_err(wm8350->dev, "Invalid LED index %d\n", lednum);
>  		return -ENODEV;
>  	}
> --

Applied.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/