linux-kernel - Re: [PATCH] platform/x86: eeepc-laptop uses INPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090117164457.GJ10825@elte.hu>
Date:	Sat, 17 Jan 2009 17:44:57 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH] platform/x86: eeepc-laptop uses INPUT


* Matthew Garrett <mjg59@...f.ucam.org> wrote:

> eeepc-laptop uses the input layer, so needs to depend on it.
> 
> Signed-off-by: Matthew Garrett <mjg@...hat.com>
> 
> ---
> 
> Ugh. The drivers in here seem to use a mixture of select and depends - 
> I've just followed what was already being used, but have no idea what 
> the convention really is here.
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index e65448e..d4908e0 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -281,6 +281,7 @@ config EEEPC_LAPTOP
>  	select BACKLIGHT_CLASS_DEVICE
>  	select HWMON
>  	select RFKILL
> +	select INPUT

hm, that looks wrong - selecting an interactive option like CONFIG_INPUT 
is a bad idea and can lead to further dependency problems. depends-on 
might be better. (any distro kernel will have INPUT enabled anyway, so 
this is not a reduction in utility)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/