[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090117221242.GA3962@redhat.com>
Date: Sat, 17 Jan 2009 23:12:42 +0100
From: Oleg Nesterov <oleg@...hat.com>
To: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
Cc: ebiederm@...ssion.com, roland@...hat.com, bastian@...di.eu.org,
daniel@...ac.com, xemul@...nvz.org, containers@...ts.osdl.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7][v7] Protect cinit from unblocked SIG_DFL signals
On 01/17, Sukadev Bhattiprolu wrote:
>
> @@ -1331,7 +1341,7 @@ int send_sigqueue(struct sigqueue *q, struct task_struct *t, int group)
> goto ret;
>
> ret = 1; /* the signal is ignored */
> - if (!prepare_signal(sig, t))
> + if (!prepare_signal(sig, t, 1))
Hmm, just noticed. This looks wrong, it should be prepare_signal(sig, t, 0),
no?
For example, /sbin/init can create the posix timer with sigev_signo = SIGKILL
and it won't be killed before this patch.
This also looks wrong from the masquerading pov.
Otherwise, the patches 1-6 are imho fine.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists