linux-kernel - Re: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1232294164.24415.3.camel@localhost.localdomain>
Date:	Sun, 18 Jan 2009 21:26:04 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Hannes Eder <hannes@...neseder.net>
Cc:	dri-devel@...ts.sourceforge.net, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport
 symbols

On Sun, 2009-01-18 at 16:28 +0100, Hannes Eder wrote:
> Fix this sparse warnings:
> 
>   drivers/gpu/drm/drm_crtc_helper.c:137:6: warning: symbol 'drm_helper_probe_connector_modes' was not declared. Should it be static?
>   drivers/gpu/drm/drm_modes.c:360:6: warning: symbol 'drm_mode_validate_clocks' was not declared. Should it be static?
> 
> Signed-off-by: Hannes Eder <hannes@...neseder.net>
> ---
>  drivers/gpu/drm/drm_crtc_helper.c |    6 +++---
>  drivers/gpu/drm/drm_modes.c       |    7 +++----
>  2 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> index d8a982b..a0b2601 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -134,8 +134,9 @@ void drm_helper_probe_single_connector_modes(struct drm_connector *connector,
>  }
>  EXPORT_SYMBOL(drm_helper_probe_single_connector_modes);
>  
> -void drm_helper_probe_connector_modes(struct drm_device *dev, uint32_t maxX,
> -				      uint32_t maxY)
> +static void drm_helper_probe_connector_modes(struct drm_device *dev,
> +					     uint32_t maxX,
> +					     uint32_t maxY)
>  {
>  	struct drm_connector *connector;
>  
> @@ -143,7 +144,6 @@ void drm_helper_probe_connector_modes(struct drm_device *dev, uint32_t maxX,
>  		drm_helper_probe_single_connector_modes(connector, maxX, maxY);
>  	}
>  }
> -EXPORT_SYMBOL(drm_helper_probe_connector_modes);
>  

hmm, what you are trying to do ?

> 
>  /**
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index 7c36f16..c0cfe39 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -357,9 +357,9 @@ EXPORT_SYMBOL(drm_mode_validate_size);
>   * sure each mode falls within a given range (defined by @min and @max
>   * arrays) and sets @mode->status as needed.
>   */
> -void drm_mode_validate_clocks(struct drm_device *dev,
> -			      struct list_head *mode_list,
> -			      int *min, int *max, int n_ranges)
> +static void drm_mode_validate_clocks(struct drm_device *dev,
> +				     struct list_head *mode_list,
> +				     int *min, int *max, int n_ranges)
>  {
>  	struct drm_display_mode *mode;
>  	int i;
> @@ -376,7 +376,6 @@ void drm_mode_validate_clocks(struct drm_device *dev,
>  			mode->status = MODE_CLOCK_RANGE;
>  	}
>  }
> -EXPORT_SYMBOL(drm_mode_validate_clocks);

??

--
JSR


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/