linux-kernel - Re: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0901181710000.661@ask.diku.dk>
Date:	Sun, 18 Jan 2009 17:11:10 +0100 (CET)
From:	Julia Lawall <julia@...u.dk>
To:	Hannes Eder <hannes@...neseder.net>
Cc:	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	dri-devel@...ts.sourceforge.net, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport
 symbols

> >> -EXPORT_SYMBOL(drm_mode_validate_clocks);
> >
> > ??
> 
> In both cases: a grep over the entire kernel tree shows that the
> function is only used within the compilation unit it is defined,
> therefore make it static and un-EXPORT it.

I don't know anything about this specific context, but aren't things in 
general exported so that external modules can use them?  If that is the 
case, grepping over the kernel sources is not sufficient.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/