[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1232247901.3097.12.camel@localhost.localdomain>
Date: Sun, 18 Jan 2009 08:35:01 +0530
From: Jaswinder Singh Rajput <jaswinder@...nel.org>
To: Sam Ravnborg <sam@...nborg.org>
Cc: David Woodhouse <dwmw2@...radead.org>, Ingo Molnar <mingo@...e.hu>,
x86 maintainers <x86@...nel.org>, urs.thuermann@...kswagen.de,
oliver.hartkopp@...kswagen.de, linux-media@...r.kernel.org,
netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
bfields@...ldses.org, neilb@...e.de, linux-nfs@...r.kernel.org,
linux-raid@...r.kernel.org, dbrownell@...rs.sourceforge.net,
spi-devel-general@...ts.sourceforge.net, netdev@...r.kernel.org,
greg@...ah.com, linux-usb@...r.kernel.org,
linux-mtd@...ts.infradead.org, tiwai@...e.de,
mchehab@...radead.org, LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
Hello Sam, David,
On Sat, 2009-01-17 at 23:19 +0100, Sam Ravnborg wrote:
> On Sun, Jan 18, 2009 at 08:37:41AM +1100, David Woodhouse wrote:
> > On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote:
> > > --- a/include/linux/dvb/audio.h
> > > +++ b/include/linux/dvb/audio.h
> > > @@ -24,9 +24,8 @@
> > > #ifndef _DVBAUDIO_H_
> > > #define _DVBAUDIO_H_
> > >
> > > -#ifdef __KERNEL__
> > > #include <linux/types.h>
> > > -#else
> > > +#ifndef __KERNEL__
> > > #include <stdint.h>
> > > #endif
> > >
> >
> > That patch looks wrong, and unnecessary. It was fine before.
> Nope - include/linux/dvb/audio.h failed to include linux/types.h
> despite the fact that is uses __u32 etc.
>
CHECK include/mtd (6 files)
/home/jaswinder/jaswinder-git/linux-2.6-tip/usr/include/mtd/jffs2-user.h:20: extern's make no sense in userspace
--
include/mtd/jffs2-user.h:
extern int target_endian;
#define t16(x) ({ uint16_t __b = (x); (target_endian==__BYTE_ORDER)?__b:bswap_16(__b); })
#define t32(x) ({ uint32_t __b = (x); (target_endian==__BYTE_ORDER)?__b:bswap_32(__b); })
--
In above case extern is OK or not ?
Do we have some better alternative.
Thanks
--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists