linux-kernel - Re: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154e089b0901180942o46b80006q5e0d586cb3e1841c@mail.gmail.com>
Date:	Sun, 18 Jan 2009 18:42:06 +0100
From:	"Hannes Eder" <hannes@...neseder.net>
To:	"Julia Lawall" <julia@...u.dk>,
	"Jaswinder Singh Rajput" <jaswinder@...nel.org>
Cc:	dri-devel@...ts.sourceforge.net, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols

On Sun, Jan 18, 2009 at 5:11 PM, Julia Lawall <julia@...u.dk> wrote:
> I don't know anything about this specific context, but aren't things in
> general exported so that external modules can use them?  If that is the
> case, grepping over the kernel sources is not sufficient.

Good point, but it indicates that the function does not have a caller
within kernel tree.
Ok, there could be other clients.  So this patch might just be a hint
for the original author or maintainer that there is maybe no need to
export this function.

On Sun, Jan 18, 2009 at 5:18 PM, Jaswinder Singh Rajput
<jaswinder@...nel.org> wrote:
> If it is EXPORTED you cannot make it static. EXPORTED means it can be
> used from a kernel module.

Right, that's why I have made it static and removed the EXPORT_SYMBOL,
all under the assumption that there is _no_ client for this function,
but there may be some outside the kernel tree.  I can not judge this.

Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/