linux-kernel - Re: [PATCH][ATA] Add ide-disk led-trigger to ATA subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090118182955.5e994064@lxorguk.ukuu.org.uk>
Date:	Sun, 18 Jan 2009 18:29:55 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Pavel Machek <pavel@...e.cz>,
	Carsten Schlote <c.schlote@...zeptpark.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][ATA] Add ide-disk led-trigger to ATA subsystem

On Sun, 18 Jan 2009 10:50:30 -0500
Jeff Garzik <jeff@...zik.org> wrote:

> Pavel Machek wrote:
> > On Sat 2009-01-10 16:08:27, Carsten Schlote wrote:
> >>  void ata_sff_exec_command(struct ata_port *ap, const struct
> >> ata_taskfile *tf)
> >>  {
> >> +	ledtrig_ide_activity();
> >> +
> >>  	DPRINTK("ata%u: cmd 0x%X\n", ap->print_id, tf->command);
> >>  
> >>  	iowrite8(tf->command, ap->ioaddr.command_addr);
> >>
> > 
> > Is there a more generic place so that we won't have to modify all the
> > libata drivers?
> 
> 
> One would think you could do this at the block layer...

ata_sff_exec_command is also on a timing critical path so the wrong place
to be touching other stuff. It's mid command issue.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/