linux-kernel - Re: [Patch] slob: clean up the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1232307718.5202.14.camel@calx>
Date:	Sun, 18 Jan 2009 13:41:58 -0600
From:	Matt Mackall <mpm@...enic.com>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, cl@...ux-foundation.org,
	penberg@...helsinki.fi, linux-mm@...ck.org,
	Andrew Morton <akpm@...l.org>
Subject: Re: [Patch] slob: clean up the code

On Mon, 2009-01-19 at 02:00 +0800, Américo Wang wrote:
> - Use NULL instead of plain 0;

Good.

> - Rename slob_page() to is_slob_page();

Ok.

> - Define slob_page() to convert void* to struct slob_page*;

Ok. The general "struct page vs page" confusion isn't really improved by
this but at least this makes it a bit less ugly.

> - Rename slob_new_page() to slob_new_pages();

Don't care about this one. We've long had a notion of a "high order
page" (singular) of size 2^n pages.

> - Define slob_free_pages() accordingly.

This is a trivial wrapper function with one user.

But this patch is probably fine in it's current form, I don't care
enough about the above to respin it.

Signed-off-by: Matt Mackall <mpm@...enic.com>

-- 
http://selenic.com : development and support for Mercurial and Linux


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/