linux-kernel - Re: [PATCH 03/17] x86-64: Convert irqstacks to per-cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4972B6D9.4080101@kernel.org>
Date:	Sun, 18 Jan 2009 13:58:01 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Brian Gerst <brgerst@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/17] x86-64: Convert irqstacks to per-cpu

Hello,

Brian Gerst wrote:
> @@ -211,15 +211,13 @@ ENTRY(secondary_startup_64)
>  	 * data area.  Computing this requires two symbols - __per_cpu_load
>  	 * and per_cpu__gdt_page.  As linker can't do no such relocation, do
>  	 * it by hand.  As early_gdt_descr is manipulated by C code for
> -	 * secondary CPUs, this should be done only once for the boot CPU
> -	 * when early_gdt_descr_base contains zero.
> +	 * secondary CPUs, this should be done only once for the boot CPU.
>  	 */

It would probably be nice to mention that it's calculating per cpu
load addresses for early access.  The comment only refers to gdt_page
which is a bit misleading as it now also adjusts irqstackptr.

Also, as pda field name, irqstackptr might be fine but wouldn't it be
better to rename it to at least irq_stack_ptr as this change requires
touching every users anyway?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/