linux-kernel - Re: [PATCH 05/17] x86-64: Move cpu number from PDA to per-cpu and consolidate with 32-bit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4972C53C.5050509@kernel.org>
Date:	Sun, 18 Jan 2009 14:59:24 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Brian Gerst <brgerst@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/17] x86-64: Move cpu number from PDA to per-cpu and
 	consolidate with 32-bit.

Brian Gerst wrote:
> On Sun, Jan 18, 2009 at 12:05 AM, Tejun Heo <tj@...nel.org> wrote:
>> Hello,
>>
>>> --- a/arch/x86/kernel/setup_percpu.c
>>> +++ b/arch/x86/kernel/setup_percpu.c
>>> @@ -147,6 +147,9 @@ unsigned long __per_cpu_offset[NR_CPUS] __read_mostly;
>>>  #endif
>>>  EXPORT_SYMBOL(__per_cpu_offset);
>>>
>>> +DEFINE_PER_CPU(int, cpu_number);
>>> +EXPORT_PER_CPU_SYMBOL(cpu_number);
>> This is inside CONFIG_HAVE_SETUP_PER_CPU_AREA.  I think voyage would
>> be unhappy with this change.
> 
> Is there any specific reason Voyager doesn't use the x86
> setup_per_cpu_areas() function?  I don't see anything on a quick
> glance that would not work.  The x86 code is pretty much a superset of
> the default code in init/main.c.

I have no idea at all.  Given that not many people can test it, I
figured just leaving it alone would be the best course but if it can
be merged, all the better.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/