linux-kernel - Re: [GIT PULL -tip] fix 41 'make headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090119105956.573d434f.sfr@canb.auug.org.au>
Date:	Mon, 19 Jan 2009 10:59:56 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sam Ravnborg <sam@...nborg.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL -tip] fix 41 'make headers_check' warnings

Hi Jaswinder,

On Sun, 18 Jan 2009 15:40:54 +0530 Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
>
> 
> /home/jaswinder/jaswinder-git/linux-2.6-tip/usr/include/linux/pkt_cls.h:306: leaks CONFIG_NET to userspace where it is not valid
> /home/jaswinder/jaswinder-git/linux-2.6-tip/usr/include/linux/pkt_cls.h:307: leaks CONFIG_NET to userspace where it is not valid

> diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h
> index 3c842ed..7a45e09 100644
> --- a/include/linux/pkt_cls.h
> +++ b/include/linux/pkt_cls.h
> @@ -304,8 +304,8 @@ enum
>  	TCA_FW_UNSPEC,
>  	TCA_FW_CLASSID,
>  	TCA_FW_POLICE,
> -	TCA_FW_INDEV, /*  used by CONFIG_NET_CLS_IND */
> -	TCA_FW_ACT, /* used by CONFIG_NET_CLS_ACT */
> +	TCA_FW_INDEV,	/* used by NET_CLS_IND */
> +	TCA_FW_ACT,	/* used by NET_CLS_ACT */
>  	TCA_FW_MASK,

Again, surely we can improve the tool to not warn about these.  If nothing
else, the actual warning is not correct.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped