linux-kernel - Re: [PATCH 1/1] relay: fix lock imbalance in relay_late_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090119101509.GG30821@kernel.dk>
Date:	Mon, 19 Jan 2009 11:15:10 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>,
	Jens Axboe <axboe@...e.de>
Subject: Re: [PATCH 1/1] relay: fix lock imbalance in relay_late_setup_files

On Sat, Jan 17 2009, Jiri Slaby wrote:
> One fail path in relay_late_setup_files() omits
> mutex_unlock(&relay_channels_mutex);
> Add it.
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Cc: Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
> Cc: Jens Axboe <axboe@...e.de>
> ---
>  kernel/relay.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

Looks good, applied!

> 
> diff --git a/kernel/relay.c b/kernel/relay.c
> index 8ca1587..738bc85 100644
> --- a/kernel/relay.c
> +++ b/kernel/relay.c
> @@ -714,8 +714,10 @@ int relay_late_setup_files(struct rchan *chan,
>  
>  	mutex_lock(&relay_channels_mutex);
>  	/* Is chan already set up? */
> -	if (unlikely(chan->has_base_filename))
> +	if (unlikely(chan->has_base_filename)) {
> +		mutex_unlock(&relay_channels_mutex);
>  		return -EEXIST;
> +	}
>  	chan->has_base_filename = 1;
>  	chan->parent = parent;
>  	curr_cpu = get_cpu();
> -- 
> 1.6.1
> caught by stanse
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/