linux-kernel - Re: [PATCH 07/10] omap mailbox: add save_/restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090119.123612.153133347.Hiroshi.DOYU@nokia.com>
Date:	Mon, 19 Jan 2009 12:36:12 +0200 (EET)
From:	Hiroshi DOYU <Hiroshi.DOYU@...ia.com>
To:	linux@....linux.org.uk
Cc:	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.arm.linux.org.uk, linux-omap@...r.kernel.org
Subject: Re: [PATCH 07/10] omap mailbox: add save_/restore_ctx() for PM

Hi Russell, Thank you for your review.

From: "ext Russell King - ARM Linux" <linux@....linux.org.uk>
Subject: Re: [PATCH 07/10] omap mailbox: add save_/restore_ctx() for PM
Date: Sat, 17 Jan 2009 17:20:37 +0000

> On Sat, Jan 17, 2009 at 05:10:44PM +0000, Russell King - ARM Linux wrote:
> > On Fri, Jan 16, 2009 at 10:27:37AM +0200, Hiroshi DOYU wrote:
> > > diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
> > > index a877305..544dde9 100644
> > > --- a/arch/arm/mach-omap2/mailbox.c
> > > +++ b/arch/arm/mach-omap2/mailbox.c

[...]

> Hmm, don't forget 'i' is an offset not an index, so...
> 
> £define MBOX_NR_REGS (MBOX_REG_SIZE / sizeof(u32))
> 
> 	for (i = 0; i < MBOX_NR_REGS; i++) {
> 		p->ctx[i] = mbox_read_reg(i * sizeof(u32));

The updated one is attached.

> (you'll have to excuse the '£' there - my keyboard currently does not have
> a 'hash' key for some Fedora 9 post upgrade silly reason.)

No problem, just sorry for you inconvenience;)


Just for convenience, I provided a branch for the latest "mailbox"
patchset as below:

The following changes since commit 1de9e8e70f5acc441550ca75433563d91b269bbe:
  Linus Torvalds (1):
        Linux 2.6.29-rc2

are available in the git repository at:

  http://git.gitorious.org/lk/mainline.git mailbox

Hiroshi DOYU (10):
      omap mailbox: cleanup omap2 register definition with macro
      omap mailbox: add initial omap3 support
      omap mailbox: print hardware revision at startup
      omap mailbox: fix empty struct device for omap_mbox
      omap mailbox: fix empty struct device for omap1
      omap mailbox: fix empty struct device for omap2
      omap mailbox: add save_/restore_ctx() for PM
      omap mailbox: move mailbox.h into mailbox.c
      omap mailbox: convert sequence bit checking to module paramter
      omap mailbox: remove unnecessary header file inclusion

 arch/arm/mach-omap1/devices.c              |    2 +-
 arch/arm/mach-omap1/mailbox.c              |   31 +++--
 arch/arm/mach-omap2/devices.c              |   39 ++++--
 arch/arm/mach-omap2/mailbox.c              |  197 ++++++++++++++++------------
 arch/arm/plat-omap/Kconfig                 |    8 +
 arch/arm/plat-omap/include/mach/mailbox.h  |   27 ++++-
 arch/arm/plat-omap/include/mach/omap34xx.h |    1 +
 arch/arm/plat-omap/mailbox.c               |  152 ++++++++++++++++------
 arch/arm/plat-omap/mailbox.h               |  100 --------------
 9 files changed, 311 insertions(+), 246 deletions(-)
 delete mode 100644 arch/arm/plat-omap/mailbox.h

View attachment "omap-mailbox-add-save_-restore" of type "Text/Plain" (3277 bytes)