linux-kernel - Re: [PATCH] sector_t last is unsigned, so cannot be less than 0.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090119131828.GC10193@duck.suse.cz>
Date:	Mon, 19 Jan 2009 14:18:28 +0100
From:	Jan Kara <jack@...e.cz>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	jack@...e.cz, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sector_t last is unsigned, so cannot be less than 0.

  Hi Roel,

On Sun 18-01-09 23:45:13, Roel Kluin wrote:
> sector_t last is unsigned, so cannot be less than 0.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index e25e701..1f3941d 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -721,7 +721,7 @@ static sector_t udf_scan_anchors(struct super_block *sb, sector_t lastblock)
>  	 *  however, if the disc isn't closed, it could be 512 */
>  
>  	for (i = 0; i < ARRAY_SIZE(last); i++) {
> -		if (last[i] < 0)
> +		if (last[i] > lastblock + 1)
>  			continue;
>  		if (last[i] >= sb->s_bdev->bd_inode->i_size >>
>  				sb->s_blocksize_bits)
  I already have your cleanup of this check in my UDF tree. I'm sorry it's not
in Linus's tree yet but I forgot to merge it with Linus during the merge
window..

									Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/