linux-kernel - Re: [PATCH 4/5] cpumask: convert drivers/net/sfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1232384910.31644.13.camel@achroite>
Date:	Mon, 19 Jan 2009 17:08:30 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Mike Travis <travis@....com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Jack Steiner <steiner@....com>,
	linux-kernel@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH 4/5] cpumask: convert drivers/net/sfc

On Wed, 2009-01-07 at 11:58 -0800, Mike Travis wrote:
> From: Rusty Russell <rusty@...tcorp.com.au>
> 
> Impact: reduce stack usage, use new cpumask API.
> 
> Remove a cpumask from the stack.  Ben Hutchings indicated that printing
> a warning and returning 1 was acceptable for the corner case where allocation
> fails.
> 
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> Signed-off-by: Mike Travis <travis@....com>
> Cc: Ben Hutchings <bhutchings@...arflare.com>
> Cc: linux-net-drivers@...arflare.com
Acked-by: Ben Hutchings <bhutchings@...arflare.com>

This seems to work.

> ---
>  drivers/net/sfc/efx.c |   15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c
> --- a/drivers/net/sfc/efx.c
> +++ b/drivers/net/sfc/efx.c
> @@ -854,20 +854,27 @@ static void efx_fini_io(struct efx_nic *
>   * interrupts across them. */
>  static int efx_wanted_rx_queues(void)
>  {
> -	cpumask_t core_mask;
> +	cpumask_var_t core_mask;
>  	int count;
>  	int cpu;
>  
> -	cpus_clear(core_mask);
> +	if (!alloc_cpumask_var(&core_mask, GFP_KERNEL)) {
> +		printk(KERN_WARNING
> +		       "efx.c: allocation failure, irq balancing hobbled\n");
[...]

This is an exceedingly unlikely error case so the error message is not
that important, but if you don't mind re-spinning this then please make
it "sfc: RSS disabled due to allocation failure\n".

(Device-related log messages should also include the device address, but
I don't want to add a device parameter to the function just for that.
Maybe we should call this function just once at module init time since
the result is not device-specific.)

Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/