linux-kernel - Re: [PATCH 2/6] ide: move SFF I/O code to ide-io-sff.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4974C030.5020509@ru.mvista.com>
Date:	Mon, 19 Jan 2009 21:02:24 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] ide: move SFF I/O code to ide-io-sff.c

Hello.

Alan Cox wrote:

>>>[ I'm also not happy with the naming but couldn't think of a better one. ]

>>    Legacy perhaps?

> Legacy to most people means either ISA/VLB or the PCI legacy
> compatibility mode so that would be confusing.

    That's what this code is for (minus the MMIO accessors perhaps).

> BTW if you moved to ioreadX you could get rid of almost all the readb/inb
> special casing.

    And burden the driver code with function calls ISO in/out instructions, at 
least on x86. It's somewhat arguable move.

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/