linux-kernel - Re: [PATCH 0/20] return f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1232393334.5893.42.camel@norville.austin.ibm.com>
Date:	Mon, 19 Jan 2009 13:28:54 -0600
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	coly.li@...e.de
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	"Sergey S. Kostyliov" <rathamahata@...4.ru>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>,
	Dave Kleikamp <shaggy@...tin.ibm.com>,
	Bob Copeland <me@...copeland.com>,
	Anders Larsen <al@...rsen.net>, reiserfs-devel@...r.kernel.org,
	Phillip Lougher <phillip@...gher.demon.co.uk>,
	Christoph Hellwig <hch@...radead.org>,
	Evgeniy Dushistov <dushistov@...l.ru>, Jan Kara <jack@...e.cz>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 0/20] return f_fsid for statfs(2)

These patches probably belong in linux-fsdevel, but I hesitate to ask
you to repost all twenty.

On Tue, 2009-01-20 at 01:30 +0800, Coly Li wrote:
> Currently many file systems in Linux kernel do not return f_fsid in statfs info, the value is set as
> 0 in vfs layer. Anyway, in some conditions, f_fsid from statfs(2) is useful, especially being used
> as (f_fsid, ino) pair to uniquely identify a file.
> 
> Basic idea of the patches is generating a unique fs ID by huge_encode_dev(sb->s_bdev->bd_dev) during
> file system mounting life time (no endian consistent issue). sb is a point of struct super_block of
> current mounted file system being accessed by statfs(2).

ext[234] return a portion of the uuid in f_fsid.  There is a theoretical
chance of those values being non-unique.  Since there doesn't appear to
be any case for the fsid to be persistent between boots, I guess
huge_encode_dev() is probably a better choice.  In practice it probably
makes no difference.

> The patches are quite simple, any feedback or patch review is welcome.

They look reasonable to me.

Shaggy
-- 
David Kleikamp
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/