linux-kernel - Re: [PATCH 3/6] ide: small ide_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1232405064.23611.69.camel@pasglop>
Date:	Tue, 20 Jan 2009 09:44:24 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	Andreas Schwab <schwab@...e.de>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] ide: small ide_register_port() cleanup


> Since it is the second time this ->parent special case bited us in the *ss:
> 
> pmac_ide_macio_attach():
> ...
> 	hw.dev = &mdev->bus->pdev->dev;
> 	hw.parent = &mdev->ofdev.dev;
> ...
> 
> I again wonder what is the reason for having different struct device-s used
> for DBDMA and for device tree on MACIO PMAC controllers.  Maybe there is no
> real reason after all and we can use &mdev->ofdev.dev also for hwif->dev?

Historically, dma_map_* wasn't supported on the macio devs, had to use
the underlying pci dev.

In fact, it might even still be the case. I need to have a look at it
after LCA, though with our current DMA ops, it should be easy to fix.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/