[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1232333594.3129.31.camel@localhost.localdomain>
Date: Mon, 19 Jan 2009 08:23:14 +0530
From: Jaswinder Singh Rajput <jaswinder@...nel.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
urs.thuermann@...kswagen.de, oliver.hartkopp@...kswagen.de,
linux-media@...r.kernel.org, netfilter-devel@...r.kernel.org,
netfilter@...r.kernel.org, bfields@...ldses.org, neilb@...e.de,
linux-nfs@...r.kernel.org, linux-raid@...r.kernel.org,
dbrownell@...rs.sourceforge.net,
spi-devel-general@...ts.sourceforge.net, netdev@...r.kernel.org,
greg@...ah.com, linux-usb@...r.kernel.org, dwmw2@...radead.org,
linux-mtd@...ts.infradead.org, tiwai@...e.de,
mchehab@...radead.org, LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
On Mon, 2009-01-19 at 11:24 +1100, Stephen Rothwell wrote:
> On Sun, 18 Jan 2009 01:47:21 +0530 Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
> >
> > diff --git a/include/linux/nfsd/stats.h b/include/linux/nfsd/stats.h
> > index 7678cfb..0b53cfe 100644
> > --- a/include/linux/nfsd/stats.h
> > +++ b/include/linux/nfsd/stats.h
> > @@ -29,9 +29,11 @@ struct nfsd_stats {
> > unsigned int ra_size; /* size of ra cache */
> > unsigned int ra_depth[11]; /* number of times ra entry was found that deep
> > * in the cache (10percentiles). [10] = not found */
> > +#ifdef __KERNEL__
> > #ifdef CONFIG_NFSD_V4
> > unsigned int nfs4_opcount[LAST_NFS4_OP + 1]; /* count of individual nfsv4 operations */
> > #endif
> > +#endif /* __KERNEL__ */
> >
> > };
>
> The only variable in the kernel of type "struct nfsd_stats" is only
> exported to user mode via procfs, so this whole structure could probably
> go inside __KERNEL__. Then looking harder, I wonder if this header
> should be exported to user mode at all.
>
I was in doubt may be this will be used by some userspace utilities.
Once I got confirmation that it is not required in userspace, I will
remove it :-)
--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists