linux-kernel - Re: [GIT PULL -tip] fix 41 'make headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090119144811.d1da89a4.sfr@canb.auug.org.au>
Date:	Mon, 19 Jan 2009 14:48:11 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sam Ravnborg <sam@...nborg.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL -tip] fix 41 'make headers_check' warnings

Hi Jaswinder,

On Mon, 19 Jan 2009 08:01:14 +0530 Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
>
> On Mon, 2009-01-19 at 10:53 +1100, Stephen Rothwell wrote:
> > 
> > On Sun, 18 Jan 2009 15:40:54 +0530 Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
> > >
> > > diff --git a/include/linux/pktcdvd.h b/include/linux/pktcdvd.h
> > > index 04b4d73..277de8c 100644
> > > --- a/include/linux/pktcdvd.h
> > > +++ b/include/linux/pktcdvd.h
> > > @@ -33,11 +33,15 @@
> > >   * able to sucessfully recover with this option (drive will return good
> > >   * status as soon as the cdb is validated).
> > >   */
> > > +#ifdef __KERNEL__
> > >  #if defined(CONFIG_CDROM_PKTCDVD_WCACHE)
> > >  #define USE_WCACHING		1
> > >  #else
> > >  #define USE_WCACHING		0
> > >  #endif
> > > +#else /* __KERNEL__ */
> > > +#define USE_WCACHING		0
> > > +#endif /* __KERNEL__ */
> > 
> > This also only has one user (drivers/block/pktcdvd.c) so maybe it should
> > be moved there.
> > 
> 
> Already fixed in v3 as pointed by Ingo.

I was actually suggesting that you move the whole 

#if defined(CONFIG_CDROM_PKTCDVD_WCACHE)
#define USE_WCACHING		1
#else
#define USE_WCACHING		0
#endif

into drivers/block/pktcdvd.c as that is the only place USE_WCACHING is
used.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped