[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1232480940.22233.1435.camel@macbook.infradead.org>
Date: Wed, 21 Jan 2009 06:49:00 +1100
From: David Woodhouse <dwmw2@...radead.org>
To: Ingo Molnar <mingo@...e.hu>
Cc: Nick Piggin <npiggin@...e.de>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Bernd Schmidt <bernds_cb1@...nline.de>,
Andi Kleen <andi@...stfloor.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Harvey Harrison <harvey.harrison@...il.com>,
"H. Peter Anvin" <hpa@...or.com>,
Chris Mason <chris.mason@...cle.com>,
Peter Zijlstra <peterz@...radead.org>,
Steven Rostedt <rostedt@...dmis.org>,
paulmck@...ux.vnet.ibm.com, Gregory Haskins <ghaskins@...ell.com>,
Matthew Wilcox <matthew@....cx>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-fsdevel <linux-fsdevel@...r.kernel.org>,
linux-btrfs <linux-btrfs@...r.kernel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Peter Morreale <pmorreale@...ell.com>,
Sven Dietrich <SDietrich@...ell.com>, jh@...e.cz
Subject: Re: gcc inlining heuristics was Re: [PATCH -v7][RFC]: mutex:
implement adaptive spinning
On Tue, 2009-01-20 at 13:38 +0100, Ingo Molnar wrote:
>
> * Nick Piggin <npiggin@...e.de> wrote:
>
> > > > it seems like a nice opt-in thing that can be used where the aliases
> > > > are verified and the code is particularly performance critical...
> > >
> > > Yes. I think we could use it in the kernel, although I'm not sure how
> > > many cases we would ever find where we really care.
> >
> > Yeah, we don't tend to do a lot of intensive data processing, so it is
> > normally the cache misses that hurt most as you noted earlier.
> >
> > Some places it might be appropriate, though. It might be nice if it can
> > bring code size down too...
>
> I checked, its size effects were miniscule [0.17%] on the x86 defconfig
> kernel and it seems to be a clear loss in total cost as there would be an
> ongoing maintenance cost
They were talking about 'restrict', not strict-aliasing. Where it can be
used, it's going to give you optimisations that strict-aliasing can't.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@...el.com Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists