lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Jan 2009 17:36:02 -0800 From: Greg KH <gregkh@...e.de> To: "Rafael J. Wysocki" <rjw@...k.pl> Cc: Alan Stern <stern@...land.harvard.edu>, Andrew Morton <akpm@...ux-foundation.org>, Andrey Borzenkov <arvidjaar@...l.ru>, LKML <linux-kernel@...r.kernel.org>, USB list <linux-usb@...r.kernel.org>, pm list <linux-pm@...ts.linux-foundation.org>, Christian Borntraeger <borntraeger@...ibm.com>, Zdenek Kabelac <zdenek.kabelac@...il.com>, Ingo Molnar <mingo@...e.hu>, Jeff Chua <jeff.chua.linux@...il.com> Subject: Re: [PATCH] USB: Fix suspend-resume of PCI USB controllers On Tue, Jan 20, 2009 at 01:26:56AM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rjw@...k.pl> > > Commit a0d4922da2e4ccb0973095d8d29f36f6b1b5f703 > (USB: fix up suspend and resume for PCI host controllers) attempted > to fix the suspend-resume of PCI USB controllers, but unfortunately > it did that incorrectly and interrupts are left enabled by the USB > controllers' ->suspend_late() callback as a result. This leads to > serious problems during suspend which are very difficult to debug. > > Fix the issue by removing the ->suspend_late() callback of PCI > USB controllers and moving the code from there to the ->suspend() > callback executed with interrupts enabled. Additionally, make > the ->resume() callback of PCI USB controllers execute > pci_enable_wake(dev, PCI_D0, false) to disable wake-up from the > full power state (PCI_D0). > > Signed-off-by: Rafael J. Wysocki <rjw@...k.pl> > Tested-by: Andrey Borzenkov <arvidjaar@...l.ru> > Tested-by: "Jeff Chua" <jeff.chua.linux@...il.com> > Cc: Alan Stern <stern@...land.harvard.edu> > Cc: Andrew Morton <akpm@...ux-foundation.org> > Cc: Christian Borntraeger <borntraeger@...ibm.com> > Cc: "Zdenek Kabelac" <zdenek.kabelac@...il.com> > Cc: Ingo Molnar <mingo@...e.hu> Alan, does this look ok for you? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists