linux-kernel - Re: [PATCH] drivers/serial/8250_pci.c (add support for '8-port RS-232 MIC-3620 from advantech'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4976DF6F.2010509@wincor-nixdorf.com>
Date:	Wed, 21 Jan 2009 09:40:15 +0100
From:	Niels de Vos <niels.devos@...cor-nixdorf.com>
To:	Paulius Zaleckas <paulius.zaleckas@...tonika.lt>
CC:	Michael Bramer <michael@...support.de>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] drivers/serial/8250_pci.c (add support for '8-port RS-232
 MIC-3620 from advantech'

Paulius Zaleckas wrote:
> Michael Bramer wrote:
...
>> This Patch add the device information for the 
>> MIC-3620 8-port RS-232 cPCI card from Advantech Co. Ltd.
>>
>> Signed-off-by: Michael Bramer <grisu@...-support.de>
>> --- a/drivers/serial/8250_pci.c
>> +++ b/drivers/serial/8250_pci.c
>> @@ -31,6 +31,7 @@
>>  #include "8250.h"
>>
>>  #undef SERIAL_DEBUG_PCI
>> +#define SERIAL_DEBUG_PCI
> 
> NAK.
> 
>>  /*
>>   * init function returns:
>> @@ -768,6 +769,8 @@
>>  #define PCI_SUBDEVICE_ID_OCTPRO422     0x0208
>>  #define PCI_SUBDEVICE_ID_POCTAL232     0x0308
>>  #define PCI_SUBDEVICE_ID_POCTAL422     0x0408
>> +#define PCI_VENDOR_ID_ADVANTECH         0x13fe
>> +#define PCI_DEVICE_ID_ADVANTECH_PCI3620 0x3620

Should this not be in <include/linux/pci_ids.h>?


>>  /*
>>   * Master list of serial port init/setup/exit quirks.
>> @@ -2041,6 +2054,9 @@
>>  #endif
>>
>>  static struct pci_device_id serial_pci_tbl[] = {
>> +       {       PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620,
>> +               0x3620, PCI_ANY_ID, 0, 0,

Why not use PCI_VENDOR_ID_ADVANTECH as PCI_SUBVENDOR_ID too?

Cheers,
Niels


Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)