linux-kernel - Re: libata, devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49770E08.6040204@gmail.com>
Date:	Wed, 21 Jan 2009 20:59:04 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Mark Lord <liml@....ca>
CC:	Grant Grundler <grundler@...gle.com>,
	IDE/ATA development list <linux-ide@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Jeff Garzik <jgarzik@...ox.com>, linux-pci@...r.kernel.org
Subject: Re: libata, devm_*, and MSI ?

Hello, Mark.

Sorry about slacking off.  Having way too much fun mucking around
assembly code lately.

Mark Lord wrote:
> I believe that other MSI users might want something similar,
> or perhaps Tejun could extend devres to include a pair
> of suitable functions, devm_enable_msi() and  devm_disable_msi().
> Then it would be just automatic for drivers, without any fuss.

devres does handle MSI.  Please take a look at pcim_release() in
drivers/pci/pci.c.  msi/msix enabledness is tracked by
pdev->msi[x]_enabled and if either one was enabled on a managed PCI
device, it would be disabled on driver detach, so there's no reason to
worry about it.

Also, there is no reason for low level driver to dingle with intx.  In
fact, it shouldn't as PCI quirk is supposed to handle all the pretty
quirkiness.  The intx code was there before the quirk code was in
place and no one went after them.  They should go and probably won't
cause any problem in the process.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/