linux-kernel - Re: Confusion in usr/include/asm-generic/fcntl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Jan 2009 13:13:16 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Helge Deller <deller@....de>, David Miller <davem@...emloft.net>,
	jaswinder@...nel.org, mingo@...e.hu, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org,
	Kyle McMartin <kyle@...artin.ca>
Subject: Re: Confusion in usr/include/asm-generic/fcntl.h

On Wednesday 21 January 2009, Sam Ravnborg wrote:
> Could we add a new symbol for this?
> We know we are going to use this in several places so a simpler variant
> would be more readable.
> 
> Something like:
> 
> #ifdef __64BIT
> ...
> #endif
> 
> When we define __64BIT we would use the  __BITS_PER_LONG == 64 check.

I would prefer using the __BITS_PER_LONG == 64 check directly, because
it gives you a warning when __BITS_PER_LONG is undefined, whereas the
#ifdef check gets easily fooled by include order problems. Note that
this is not a problem in the kernel for CONFIG_* symbols which are
always defined before the first #include.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/