linux-kernel - Re: [PATCH 2/2] PCI PCIe portdrv: Fix allocation of interrupts (rev. 6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200901211653.30353.rjw@sisk.pl>
Date:	Wed, 21 Jan 2009 16:53:29 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Cc:	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	Matthew Wilcox <willy@...ux.intel.com>
Subject: Re: [PATCH 2/2] PCI PCIe portdrv: Fix allocation of interrupts (rev. 6)

On Wednesday 21 January 2009, Hidetoshi Seto wrote:
> Reviewed-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
> 
> Nice work, Rafael!

Thanks for the review!

Best,
Rafael


> Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@...k.pl>
> > 
> > If MSI-X interrupt mode is used by the PCI Express port driver, too
> > many vectors are allocated and it is not ensured that the right
> > vectors will be used for the right services.  Namely, the PCI Express
> > specification states that both PCI Express native PME and PCI Express
> > hotplug will always use the same MSI or MSI-X message for signalling
> > interrupts, which implies that the same vector will be used by both
> > of them.  Also, the VC service does not use interrupts at all.
> > Moreover, is not clear which of the vectors allocated by
> > pci_enable_msix() in the current code will be used for PME and
> > hotplug and which of them will be used for AER if all of these
> > services are configured.
> > 
> > For these reasons, rework the allocation of interrupts for PCI
> > Express ports so that if MSI-X are enabled, the right vectors will be
> > used for the right purposes.
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> > ---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/