linux-kernel - Re: [PATCH] Make PNP IDs all uppercase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac3eb2510901210930r1d9f0609w86bddbb6b363c79a@mail.gmail.com>
Date:	Wed, 21 Jan 2009 18:30:08 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
Cc:	Philipp Kohlbecher <xt28@....de>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, Vojtech Pavlik <vojtech@....cz>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	Pau Oliva Fora <pof@...ack.org>,
	Hans Verkuil <hverkuil@...all.nl>,
	"David S. Miller" <davem@...emloft.net>,
	Jaroslav Kysela <perex@...ex.cz>, Adam Belay <abelay@....edu>,
	Len Brown <lenb@...nel.org>,
	Jonathan Woithe <jwoithe@...sics.adelaide.edu.au>,
	Carlos Corbacho <carlos@...angeworlds.co.uk>,
	linux-acpi@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Make PNP IDs all uppercase

On Wed, Jan 21, 2009 at 18:09, Bjorn Helgaas <bjorn.helgaas@...com> wrote:
> On Wednesday 21 January 2009 12:56:07 am Philipp Kohlbecher wrote:
>> Bjorn Helgaas wrote:

>> > Did you trip over an actual problem that is fixed by this patch?  If
>> > so, can you give any more details?
>>
>> Yes. After a package update, hwclock stopped using the "--directisa"
>> switch and could not access the RTC anymore. My RTC is handled by
>> rtc-cmos, which is compiled as a module. However, udev did not load this
>> module, as the device's modalias "acpi:PNP0B00:" did not match any of
>> the module's aliasas, including "acpi*:PNP0b00:*". Thus, the system
>> clock was not set correctly at startup (my hardware clock is set to
>> local time). Changing the PNP IDs in drivers/rtc/rtc-cmos.c to use
>> uppercase hex digits solved that problem for me.
>
> Nice work debugging that problem!  I would include that synopsis in
> the changelog, because it helps people who trip over the same problem
> and are looking for a solution, and it helps people who want to
> understand why the change was made.

We uppercase all acpi alias strings now, so that should be solved:
  http://git.kernel.org/?p=linux/kernel/git/gregkh/patches.git;a=blob;f=driver-core.current/pnp-fix-broken-pnp-lowercasing-for-acpi-module-aliases.patch;hb=HEAD

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/