linux-kernel - Re: tty_tiocmset() masks out TIOCM_RI and TIOCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee007d8e0901211013i7a5b3bc9w23c9c94e88296c0@mail.gmail.com>
Date:	Wed, 21 Jan 2009 10:13:02 -0800
From:	Adam Bliss <abliss@...gle.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org,
	Russell King <rmk@...nt.arm.linux.org.uk>,
	Marcel Holtmann <marcel@...tmann.org>
Subject: Re: tty_tiocmset() masks out TIOCM_RI and TIOCM_CD, which breaks 
	rfcomm

Hi, Alan.  Thanks for the reply.

On Wed, Jan 21, 2009 at 07:32, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> I would have expected the driver to be remapping RI/CD just as it does
> for the DTR<->DSR RTS<->CTS cable switch around.
>
> It's certainly possible to fix it, but that would need a double check on
> the existing drivers and that passing new suprise bits won't do any harm.
> The real question is what should the right behaviour be - and to me that
> seems to be to logically flip all the lines not just DTR/DSR RTS/CTS

What would you expect the driver to map RI and CD to?  I don't think
there are DTE->DCE signals that correspond to RI and CD.  Possibly
OUT1 and OUT2 could be used, since I don't think these are used
anywhere else in rfcomm, but this might be unintuitive.  I'll let
Marcel address that idea.

--Adam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/