linux-kernel - Re: [PATCH PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4976688B.4050309@jp.fujitsu.com>
Date:	Wed, 21 Jan 2009 09:12:59 +0900
From:	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
CC:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PCI <linux-pci@...r.kernel.org>
Subject: Re: [PATCH PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)

Rafael J. Wysocki wrote:
[snip]
>> 	/*
>> 	 * World have broken hardwares, so even spec says numbers are constant,
>> 	 * it would be better to re-check registers after 2nd pci_enable_msix.
>> 	 * Or we just skip this.  (However this was what your concern, Rafael?)
>> 	 */
>> 	if (func_foo_do_paranoia_check(dev, msix_entries, nvec))
>> 		goto Error;	
> 
> Well, I think let's not do it for now.  If there's a system that actually
> breaks here, then we can introduce the extra checking.
> 

Agreed.

Thanks,
Kenji Kaneshige


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/