linux-kernel - Re: Doubts in usr/include/linux/elf.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090121035653.GB25366@uranus.ravnborg.org>
Date:	Wed, 21 Jan 2009 04:56:53 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Doubts in usr/include/linux/elf.h

On Wed, Jan 21, 2009 at 05:46:26AM +0530, Jaswinder Singh Rajput wrote:
> usr/include/linux/elf.h is giving 4 'make headers_check' warnings:
>  usr/include/linux/elf.h:379: extern's make no sense in userspace
>  usr/include/linux/elf.h:387: extern's make no sense in userspace
>  usr/include/linux/elf.h:401: extern's make no sense in userspace
>  usr/include/linux/elf.h:402: extern's make no sense in userspace
> 
> 
> usr/include/linux/elf.h:
> --
> #if ELF_CLASS == ELFCLASS32
> 
> extern Elf32_Dyn _DYNAMIC [];
> #define elfhdr          elf32_hdr
> #define elf_phdr        elf32_phdr
> #define elf_note        elf32_note
> #define elf_addr_t      Elf32_Off
> 
> #else
> 
> extern Elf64_Dyn _DYNAMIC [];
> #define elfhdr          elf64_hdr
> #define elf_phdr        elf64_phdr
> #define elf_note        elf64_note
> #define elf_addr_t      Elf64_Off
> 
> #endif

If my quick grep is correct we fo not define any variable named _DYNAMIC.
So you can just drop these two lines.

> 
> /* Optional callbacks to write extra ELF notes. */
> #ifndef ARCH_HAVE_EXTRA_ELF_NOTES
> static __inline__ int elf_coredump_extra_notes_size(void) { return 0; }
> static __inline__ int elf_coredump_extra_notes_write(struct file *file,
>                         loff_t *foffset) { return 0; }
> #else
> extern int elf_coredump_extra_notes_size(void);
> extern int elf_coredump_extra_notes_write(struct file *file, loff_t *foffset);
> #endif

And the above can all be wrapped in __KERNEL__.
They got renamed in 2007:
http://ozlabs.org/pipermail/cbe-oss-dev/2007-September/003276.html

So they are hardly used by userspace anyway.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/