[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090122120337.GB22594@elte.hu>
Date: Thu, 22 Jan 2009 13:03:37 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
Frederic Weisbecker <fweisbec@...il.com>,
Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 1/5] trace: do not disable wake up tracer on output of
trace
* Steven Rostedt <rostedt@...dmis.org> wrote:
> Well actually, I don't see the output causing any issues. That's another
> point. Should we work on adding all this complex code for something that
> might not every cause an issues? I added it because it did cause an
> issue with the irqs off traces, although I'm not sure that is true any
> more either. I just added it to the wakeup tracer just to be consistent.
>
> With the new trace_off switch that disables the ring buffer, and the
> stopping of the swap buffers with the switch off, I do not think that
> this code is even necessary anymore.
>
> I think I'll rip out the code from irqsoff and see if it is still an
> issue there. If not, I think we can get rid of it.
agreed - if the output itself does not disturb max-latency tracing in
practice then i'm all for ripping it out.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists