linux-kernel - Re: sparc64 build breakage...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090121.171849.220592075.davem@davemloft.net>
Date:	Wed, 21 Jan 2009 17:18:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	yinghai@...nel.org
Cc:	mpm@...enic.com, mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: sparc64 build breakage...

From: David Miller <davem@...emloft.net>
Date: Wed, 21 Jan 2009 17:15:53 -0800 (PST)

> 
> This change:
> 
> commit d7e51e66899f95dabc89b4d4c6674a6e50fa37fc
> Author: Yinghai Lu <yinghai@...nel.org>
> Date:   Wed Jan 7 15:03:13 2009 -0800
> 
>     sparseirq: make some func to be used with genirq
> 
> breaks the sparc64 build:
 ...
> arch/sparc/kernel/irq_64.c: In function ‘show_interrupts’:
> arch/sparc/kernel/irq_64.c:188: error: ‘struct kernel_stat’ has no member named ‘irqs’
> make[1]: *** [arch/sparc/kernel/irq_64.o] Error 1
> 
> This should fix it:
> 
> sparc64: Fix build by using kstat_irqs_cpu().

Actually this isn't enough, next failure:

arch/sparc/kernel/time_64.c: In function ‘timer_interrupt’:
arch/sparc/kernel/time_64.c:732: error: implicit declaration of function ‘kstat_incr_irqs_this_cpu’
make[1]: *** [arch/sparc/kernel/time_64.o] Error 1

There seems to be a disconnect in linux/kernel_stat.h about
providing the same set of interfaces whether GENERIC_IRQS
is set or not.  kstat_incr_irqs_this_cpu is one example.