[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090122164453.GA11553@deb-support.de>
Date: Thu, 22 Jan 2009 16:44:53 +0000
From: Michael Bramer <michael@...support.de>
To: Paulius Zaleckas <paulius.zaleckas@...tonika.lt>
Cc: Niels de Vos <niels.devos@...cor-nixdorf.com>,
Tosoni <jp.tosoni@...sys.fr>,
'Alan Cox' <alan@...rguk.ukuu.org.uk>,
linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] drivers/serial/8250_pci.c (add support for '8-port RS-232 MIC-3620 from advantech'
On Thu, Jan 22, 2009 at 01:47:35PM +0200, Paulius Zaleckas wrote:
> > Is the patch now ok?
>
> No :)
>
> > ----
> > This Patch add the device information for the
> > MIC-3620 8-port RS-232 cPCI card from Advantech Co. Ltd.
> >
> > Signed-off-by: Michael Bramer <grisu@...-support.de>
> > --- a/drivers/serial/8250_pci.c 2008-07-13 23:51:29.000000000 +0200
> > +++ b/drivers/serial/8250_pci.c 2009-01-17 21:37:37.000000000 +0100
> > @@ -769,6 +768,8 @@
> > #define PCI_SUBDEVICE_ID_OCTPRO422 0x0208
> > #define PCI_SUBDEVICE_ID_POCTAL232 0x0308
> > #define PCI_SUBDEVICE_ID_POCTAL422 0x0408
> > +#define PCI_VENDOR_ID_ADVANTECH 0x13fe
> > +#define PCI_DEVICE_ID_ADVANTECH_PCI3620 0x3620
>
> Use TABs for indentation here.
ok:
-----
This Patch add the device information for the
MIC-3620 8-port RS-232 cPCI card from Advantech Co. Ltd.
Signed-off-by: Michael Bramer <grisu@...-support.de>
--- a/drivers/serial/8250_pci.c 2008-07-13 23:51:29.000000000 +0200
+++ b/drivers/serial/8250_pci.c 2009-01-17 21:37:37.000000000 +0100
@@ -769,6 +768,8 @@
#define PCI_SUBDEVICE_ID_OCTPRO422 0x0208
#define PCI_SUBDEVICE_ID_POCTAL232 0x0308
#define PCI_SUBDEVICE_ID_POCTAL422 0x0408
+#define PCI_VENDOR_ID_ADVANTECH 0x13fe
+#define PCI_DEVICE_ID_ADVANTECH_PCI3620 0x3620
/*
* Master list of serial port init/setup/exit quirks.
@@ -2054,6 +2041,10 @@
#endif
static struct pci_device_id serial_pci_tbl[] = {
+ // Advantech use PCI_DEVICE_ID_ADVANTECH_PCI3620 (0x3620) as 'PCI_SUBVENDOR_ID'
+ { PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620,
+ PCI_DEVICE_ID_ADVANTECH_PCI3620, 1, 0, 0,
+ pbn_b2_8_921600 },
{ PCI_VENDOR_ID_V3, PCI_DEVICE_ID_V3_V960,
PCI_SUBVENDOR_ID_CONNECT_TECH,
PCI_SUBDEVICE_ID_CONNECT_TECH_BH8_232, 0, 0,
-----
Gruss
Grisu
--
Michael Bramer -- http://www.feuerwehr.kreuzau.de/wiki/
PGP: finger grisu@...debian.org -- Linux Sysadmin -- Use Debian Linux
"Wenn ich die Folgen geahnt hätte, wäre ich Uhrmacher geworden!"
--- Albert Einstein
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists