linux-kernel - Re: [PATCH 0/20] return f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4978CAD4.9090607@suse.de>
Date:	Fri, 23 Jan 2009 03:36:52 +0800
From:	Coly Li <coly.li@...e.de>
To:	Jamie Lokier <jamie@...reable.org>
Cc:	Andreas Dilger <adilger@....com>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	"Sergey S. Kostyliov" <rathamahata@...4.ru>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>,
	Bob Copeland <me@...copeland.com>,
	Anders Larsen <al@...rsen.net>, reiserfs-devel@...r.kernel.org,
	Phillip Lougher <phillip@...gher.demon.co.uk>,
	Christoph Hellwig <hch@...radead.org>,
	Evgeniy Dushistov <dushistov@...l.ru>, Jan Kara <jack@...e.cz>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 0/20] return f_fsid for statfs(2)



Jamie Lokier Wrote:
> Andreas Dilger wrote:
>> On Jan 20, 2009  12:30 +0800, Coly Li wrote:
>>> Ext[234] is sophisticated to have on-disk uuid record. Most file systems
>>> in the patches (except jfs and reiser3) do not have a persistent uuid,
>>> a reasonable/feasible solution without media format modification is fsid
>>> in boot/mount life cycle. That's why huge_encode_dev(sb->s_bdev->bd_dev)
>>> is used here.  For jfs and reiserfs3, is there any use case for
>>> persistent fsid cross boots ?
>> I would say yes, this is worthwhile to do, or the fsid can change between
>> boots unnecessarily.
> 
> Even FAT has a volume id which should probably be used.
> I'm guessing NTFS does too.
> 
vfat volume id is assigned manually in mkfs.vfat, vfat volumes in one machine can be assigned to
same volume id value, even worse the volume id can be modified when volume is mounted. Therefore,
IMHO it's not suitable to be used as a fsid.

-- 
Coly Li
SuSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/