linux-kernel - Re: [PATCH 13/13] drivers/watchdog: use USB API functions rather than constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090122201330.GA4501@infomag.infomag.iguana.be>
Date:	Thu, 22 Jan 2009 21:13:30 +0100
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Julia Lawall <julia@...u.dk>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 13/13] drivers/watchdog: use USB API functions rather than constants

Hi Julia,

> > diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c
> > index afb0896..b5320a8 100644
> > --- a/drivers/watchdog/pcwd_usb.c
> > +++ b/drivers/watchdog/pcwd_usb.c
> > @@ -609,9 +609,7 @@ static int usb_pcwd_probe(struct usb_interface *interface, const struct usb_devi
> >  	/* check out the endpoint: it has to be Interrupt & IN */
> >  	endpoint = &iface_desc->endpoint[0].desc;
> >  
> > -	if (!((endpoint->bEndpointAddress & USB_DIR_IN) &&
> > -	     ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK)
> > -				== USB_ENDPOINT_XFER_INT))) {
> > +	if (!usb_endpoint_is_int_in(endpoint)) {
> >  		/* we didn't find a Interrupt endpoint with direction IN */
> >  		printk(KERN_ERR PFX "Couldn't find an INTR & IN endpoint\n");
> >  		return -ENODEV;
> 
> Seems OK. I will test it this week and let you know.

Tested OK.

Will I add this into the watchdog-tree so that it can go mainline?

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/