linux-kernel - Re: [GIT PULL] Squashfs pull request for 2.6.29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020901221424l7905d88ajc5c5438fe491da6c@mail.gmail.com>
Date:	Fri, 23 Jan 2009 00:24:41 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Dave Jones <davej@...hat.com>, Greg KH <gregkh@...e.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jörn Engel <joern@...fs.org>,
	David Brown <lkml@...idb.org>,
	Phil Oester <kernel@...uxace.com>,
	Kay Sievers <kay.sievers@...y.org>,
	Phillip Lougher <phillip@...gher.demon.co.uk>,
	Christoph Hellwig <hch@...radead.org>,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [GIT PULL] Squashfs pull request for 2.6.29

Hi Ingo,

On Fri, Jan 23, 2009 at 12:16 AM, Ingo Molnar <mingo@...e.hu> wrote:
> "real review" only becomes easy if the code _is reviewable to begin with_:
> if it is written in standard coding patterns where we almost
> sub-consciously recognize bad constructs and bad practices.
>
> I've seen it time and again that if the code is cleaned up visually, real
> review and real improvements follow eventually. It's a gradual process and
> you just cannot do "real review" efficiently without what you call the
> "checkpatch crap".

Agreed. When I looked at the pile of crap in drivers/staging/winbond
at first, it was more or less impossible to even say what the hell the
driver was doing. That was because (a) there were tons of obfuscating
wrappers carried over from Windows driver APIs and (b) there's so much
dead code it's not even funny!

So yeah, doing a "real review" on that monster before we get the
basics right would probably be a complete waste of time.

                                 Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/