lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Jan 2009 11:06:32 +0900 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> Cc: Paul Menage <menage@...gle.com>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "lizf@...fujitsu.com" <lizf@...fujitsu.com>, "balbir@...ux.vnet.ibm.com" <balbir@...ux.vnet.ibm.com>, "nishimura@....nes.nec.co.jp" <nishimura@....nes.nec.co.jp>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org> Subject: Re: [PATCH 1.5/4] cgroup: delay populate css id On Wed, 21 Jan 2009 19:34:36 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote: > On Wed, 21 Jan 2009 01:36:32 -0800 > Paul Menage <menage@...gle.com> wrote: > > > On Mon, Jan 19, 2009 at 9:43 PM, KAMEZAWA Hiroyuki > > <kamezawa.hiroyu@...fujitsu.com> wrote: > > > +static void populate_css_id(struct cgroup_subsys_state *css) > > > +{ > > > + struct css_id *id = rcu_dereference(css->id); > > > + if (id) > > > + rcu_assign_pointer(id->css, css); > > > +} > > > > I don't think this needs to be split out into a separate function. > ok. > > > Also, there's no need for an rcu_dereference(), since we're holding > > cgroup_mutex. > > > Sure. I'll fix. > BTW, isn't it better to use rcu_assign_pointer to show "this pointer will be dereferenced from RCU-read-side" ? -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists