linux-kernel - Re: [PATCH 2/7] memcg : use CSS ID in memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090123170448.5eac1026.nishimura@mxp.nes.nec.co.jp>
Date:	Fri, 23 Jan 2009 17:04:48 +0900
From:	Daisuke Nishimura <nishimura@....nes.nec.co.jp>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	nishimura@....nes.nec.co.jp,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"menage@...gle.com" <menage@...gle.com>,
	"lizf@...fujitsu.com" <lizf@...fujitsu.com>,
	"balbir@...ux.vnet.ibm.com" <balbir@...ux.vnet.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/7] memcg : use CSS ID in memcg

> > +static s64 mem_cgroup_local_usage(struct mem_cgroup_stat *stat)
> > +{
> > +	s64 ret;
> > +
> It would be better to initialize it to 0.
> 
> > +	ret = mem_cgroup_read_stat(stat, MEM_CGROUP_STAT_CACHE);
> > +	ret += mem_cgroup_read_stat(stat, MEM_CGROUP_STAT_RSS);
> > +	return ret;
> > +}
> > +
Ah, ret is initialized by mem_cgroup_read_stat...

please ignore the above comment.


Thanks,
Daisuke Nishimura.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/