linux-kernel - Re: [PATCH] autofs: fix the wrong usage of the deprecated task_pgrp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1232701795.3011.39.camel@zeus.themaw.net>
Date:	Fri, 23 Jan 2009 18:09:55 +0900
From:	Ian Kent <raven@...maw.net>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, hpa@...or.com,
	Pavel Emelyanov <xemul@...nvz.org>,
	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, "Serge E. Hallyn" <serue@...ibm.com>
Subject: Re: [PATCH] autofs: fix the wrong usage of the deprecated
	task_pgrp_nr()

On Fri, 2009-01-23 at 09:13 +0100, Oleg Nesterov wrote:
> On 01/23, Ian Kent wrote:
> >
> > But I think that for debug logging we should always report numbers that
> > correspond to the object as it is seen in the global namespace as that
> > is the most likely reference point someone examining debug logging will
> > be working from.
> >
> > Oleg, what should be the recommended call to report that, instead of the
> > task_pgrp_nr() call?
> 
> task_pgrp_nr_ns(tsk, &init_pid_ns) gives the same result. Except, if the
> tsk has already exited it returns 0.
> 
> 
> But, Ian, if you prefer to use task_pgrp_nr() - just use it. Personally,
> I'd like to kill task_pgrp_nr(), but I can't "prove" it should die.

I'm not concerned with what's used so much as fitting in with the pid
namespace effort and maintaining sensible debug output. This stuff has
been in autofs4 since long before the pid namespace work began and the
changes to it weren't done by me anyway.

Ian


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/