[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090123170904.GA26083@uranus.ravnborg.org>
Date: Fri, 23 Jan 2009 18:09:04 +0100
From: Sam Ravnborg <sam@...nborg.org>
To: Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc: Jan Engelhardt <jengelh@...ozas.de>,
"H. Peter Anvin" <hpa@...nel.org>,
David Woodhouse <dwmw2@...radead.org>,
Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
urs.thuermann@...kswagen.de, oliver.hartkopp@...kswagen.de,
linux-media@...r.kernel.org, netfilter-devel@...r.kernel.org,
netfilter@...r.kernel.org, bfields@...ldses.org, neilb@...e.de,
linux-nfs@...r.kernel.org, linux-raid@...r.kernel.org,
dbrownell@...rs.sourceforge.net, netdev@...r.kernel.org,
greg@...ah.com, linux-usb@...r.kernel.org,
linux-mtd@...ts.infradead.org, tiwai@...e.de,
mchehab@...radead.org, LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
On Fri, Jan 23, 2009 at 10:01:44PM +0530, Jaswinder Singh Rajput wrote:
> On Fri, 2009-01-23 at 17:21 +0100, Sam Ravnborg wrote:
> > On Fri, Jan 23, 2009 at 05:11:13PM +0100, Jan Engelhardt wrote:
> > >
> > > On Friday 2009-01-23 17:04, Jaswinder Singh Rajput wrote:
> > > >> > diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h
> > > >> > index 89412e1..758a48c 100644
> > > >> > --- a/include/linux/dvb/audio.h
> > > >> > +++ b/include/linux/dvb/audio.h
> > > >> > @@ -24,9 +24,8 @@
> > > >> > #ifndef _DVBAUDIO_H_
> > > >> > #define _DVBAUDIO_H_
> > > >> >
> > > >> > -#ifdef __KERNEL__
> > > >> > #include <linux/types.h>
> > > >> > -#else
> > > >> > +#ifndef __KERNEL__
> > > >> > #include <stdint.h>
> > > >> > #endif
> > > >> >
> > > >>
> > > >> It seems one have objection for this. So I will again insert this in my
> > > >> new patchset.
> > > >>
> > > >
> > > >oops, s/seems one/seems no one ;-)
> > >
> > > I had an objection as previously stated -- namely that
> > > <stdint.h> should be included to remain friendly to C++0x
> > > programs which should use <cstdint> instead. Forcing
> > > stdint.h is therefore not nice.
> >
> > This is fully agreed.
> > Jaswinder - can I ask you to do this change (remove of the stdint.h include)
> > in a follow-up patch. It is two independent changes.
> > You original patch is fine as is.
>
> So is this OK:
>
> -#ifdef __KERNEL__
> #include <linux/types.h>
> -#else
> -#include <stdint.h>
> -#endif
That was what I expected the final change to look like.
If you want then combine it in one patch.
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists